<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi Pranay,</div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> igt-dev <igt-dev-bounces@lists.freedesktop.org> on behalf of Pranay Samala <pranay.samala@intel.com><br>
<b>Sent:</b> Friday, January 3, 2025 4:04 PM<br>
<b>To:</b> igt-dev@lists.freedesktop.org <igt-dev@lists.freedesktop.org><br>
<b>Cc:</b> B S, Karthik <karthik.b.s@intel.com>; Sharma, Swati2 <swati2.sharma@intel.com>; Lattannavar, Sameer <sameer.lattannavar@intel.com>; Samala, Pranay <pranay.samala@intel.com><br>
<b>Subject:</b> [PATCH i-g-t] tests/kms_plane_scaling: Add logs to skips</span>
<div> </div>
</div>
<div class="elementToProof" style="font-size: 11pt;">Having some logs for test failures & skips would<br>
make debugging much easier.<br>
<br>
Signed-off-by: Pranay Samala <pranay.samala@intel.com><br>
---<br>
tests/kms_plane_scaling.c | 3 +++<br>
1 file changed, 3 insertions(+)<br>
<br>
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c<br>
index c8c9aee31..2a8867822 100644<br>
--- a/tests/kms_plane_scaling.c<br>
+++ b/tests/kms_plane_scaling.c<br>
@@ -1577,6 +1577,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)<br>
kmstest_pipe_name(pipe), igt_output_name(output))<br>
intel_max_source_size_test(&data, pipe, output, mode,<br>
intel_paramtests[index].planesize);<br>
+ } else {<br>
+ igt_info("Unable to find the lowest " \<br>
+ "refresh rate mode\n");</div>
<div class="elementToProof" style="font-size: 11pt;"><br>
</div>
<div class="elementToProof" style="font-size: 11pt;">Imho, It would be good to add the output name and pipe name something like below, otherwise LGTM. </div>
<div class="elementToProof" style="line-height: 19px; white-space: pre; font-family: Consolas, "Courier New", monospace; font-size: 11pt; color: rgb(0, 0, 0);">
igt_info("Unable to find a mode with the lowest refresh rate for </div>
<div class="elementToProof" style="line-height: 19px; white-space: pre; font-family: Consolas, "Courier New", monospace; font-size: 11pt; color: rgb(0, 0, 0);">
output %s on pipe %s\n",</div>
<div class="elementToProof" style="line-height: 19px; white-space: pre; font-family: Consolas, "Courier New", monospace; font-size: 11pt; color: rgb(0, 0, 0);">
igt_output_name(output), kmstest_pipe_name(pipe));</div>
<div class="elementToProof" style="font-size: 11pt;"><br>
</div>
<div class="elementToProof" style="font-size: 11pt;"> }<br>
continue;<br>
}<br>
--<br>
2.34.1<br>
<br>
</div>
</body>
</html>