<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Hello Jeevan,<br>
<br>
</div>
<div dir="ltr" id="divRplyFwdMsg" class="elementToProof">
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
</div>
</div>
<div class="elementToProof" style="font-size: 11pt;">> -----Original Message-----<br>
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Kunal<br>
> Joshi<br>
> Sent: Thursday, February 27, 2025 6:01 PM<br>
> To: igt-dev@lists.freedesktop.org<br>
> Cc: Joshi, Kunal1 <kunal1.joshi@intel.com><br>
> Subject: [PATCH i-g-t 1/2] tests/intel/kms_dp_link_training: do modeset<br>
> before retrainig<br>
><br>
> Retraining can be done on enabled output.<br>
> Fix test to do modeset before retraining.<br>
><br>
> Fixes: 983ffca5ff96fd67c937691337f4488e28948aa7<br>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com><br>
> ---<br>
> tests/intel/kms_dp_link_training.c | 1 +<br>
> 1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/tests/intel/kms_dp_link_training.c<br>
> b/tests/intel/kms_dp_link_training.c<br>
> index f00376614..33e690a60 100644<br>
> --- a/tests/intel/kms_dp_link_training.c<br>
> +++ b/tests/intel/kms_dp_link_training.c<br>
> @@ -233,6 +233,7 @@ static bool run_link_rate_test(data_t *data, bool mst,<br>
> bool uhbr)<br>
><br>
> igt_display_reset(&data->display);<br>
> igt_reset_link_params(data->drm_fd, data->output);<br>
> + do_modeset(data, mst);<br>
We are performing do_modeset twice any idea why ??<br>
<br>
Right, that's a miss from myside.<br>
Will shuffle instead of adding twice.<br>
<br>
Thanks and Regards<br>
Kunal Joshi<br>
><br>
> /* Retrain at default/driver parameters */<br>
> igt_force_link_retrain(data->drm_fd, data->output,<br>
> RETRAIN_COUNT);<br>
Here also its there.<br>
> --<br>
> 2.25.1<br>
<br>
</div>
</body>
</html>