<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Hello Pranay,<br>
<br>
Please find comments inline,</p>
<div class="moz-cite-prefix">On 01-04-2025 14:50, Pranay Samala
wrote:<br>
</div>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">Original debug mask holds the mask before the test and will be
used to reset the debug mask post test.
Fixes: 56b91193b825 ("lib/igt_sysfs: Implement dynamic adjustment of debug log level")
Signed-off-by: Pranay Samala <a class="moz-txt-link-rfc2396E" href="mailto:pranay.samala@intel.com"><pranay.samala@intel.com></a>
---
lib/igt_sysfs.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c
index 2e4c2ee63..9643aab43 100644
--- a/lib/igt_sysfs.c
+++ b/lib/igt_sysfs.c
@@ -443,7 +443,7 @@ int igt_sysfs_drm_module_params_open(void)
return open(path, O_RDONLY);
}
-static int log_level = -1;
+static int original_debug_mask = -1;
/**
* igt_drm_debug_level_get:
@@ -458,8 +458,8 @@ int igt_drm_debug_level_get(int dir)
{
char buf[20];
- if (log_level >= 0)
- return log_level;
+ if (original_debug_mask >= 0)
+ return original_debug_mask;</pre>
</blockquote>
Rename <span style="white-space: pre-wrap">original_debug_mask to <span
style="white-space: normal">saved_drm_debug_mask for clarity that it's saved to be restored later.</span></span>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">
if (igt_sysfs_read(dir, "debug", buf, sizeof(buf) - 1) < 0)
return -1;
@@ -479,15 +479,15 @@ void igt_drm_debug_level_reset(void)
char buf[20];
int dir;
- if (log_level < 0)
+ if (original_debug_mask < 0)
return;
dir = igt_sysfs_drm_module_params_open();
if (dir < 0)
return;
- igt_debug("Resetting DRM debug level to %d\n", log_level);
- snprintf(buf, sizeof(buf), "%d", log_level);
+ igt_debug("Resetting DRM debug level to %d\n", original_debug_mask);</pre>
</blockquote>
<p>Change level to mask in igt_info</p>
<p><br>
</p>
<p>Thanks and Regards<br>
Kunal Joshi</p>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">
+ snprintf(buf, sizeof(buf), "%d", original_debug_mask);
igt_assert(igt_sysfs_set(dir, "debug", buf));
close(dir);
@@ -513,8 +513,8 @@ void igt_drm_debug_level_update(unsigned int new_log_level)
if (dir < 0)
return;
- log_level = igt_drm_debug_level_get(dir);
- if (log_level < 0) {
+ original_debug_mask = igt_drm_debug_level_get(dir);
+ if (original_debug_mask < 0) {
close(dir);
return;
}
</pre>
</blockquote>
</body>
</html>