<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hi,</p>
<div class="moz-cite-prefix">On 28-04-2025 11:06, Anirban, Sk wrote:<br>
</div>
<blockquote type="cite" cite="mid:3f88eb7e-f2e9-4b45-8b6d-61156db5b2e4@intel.com">
<br>
<br>
On 25-04-2025 23:36, <a class="moz-txt-link-abbreviated" href="mailto:sk.anirban@intel.com">sk.anirban@intel.com</a> wrote:
<br>
<blockquote type="cite">From: Sk Anirban
<a class="moz-txt-link-rfc2396E" href="mailto:sk.anirban@intel.com"><sk.anirban@intel.com></a>
<br>
<br>
Resolved the frequency stashing problem by accurately
<br>
dereferencing the pointers, ensuring the minimum and
<br>
maximum frequencies are correctly restored.
<br>
<br>
Signed-off-by: Sk Anirban <a class="moz-txt-link-rfc2396E" href="mailto:sk.anirban@intel.com"><sk.anirban@intel.com></a>
<br>
---
<br>
tests/intel/xe_pmu.c | 4 ++--
<br>
1 file changed, 2 insertions(+), 2 deletions(-)
<br>
<br>
diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c
<br>
index 589c7cbde..094dc0c6c 100644
<br>
--- a/tests/intel/xe_pmu.c
<br>
+++ b/tests/intel/xe_pmu.c
<br>
@@ -527,8 +527,8 @@ static void stash_gt_freq(int fd, uint32_t
**stash_min, uint32_t **stash_max)
<br>
igt_skip_on(*stash_min == NULL || *stash_max == NULL);
<br>
xe_for_each_gt(fd, gt) {
<br>
- *stash_min[gt] = xe_gt_get_freq(fd, gt, "min");
<br>
- *stash_max[gt] = xe_gt_get_freq(fd, gt, "max");
<br>
+ (*stash_min)[gt] = xe_gt_get_freq(fd, gt, "min");
<br>
+ (*stash_max)[gt] = xe_gt_get_freq(fd, gt, "max");
<br>
}
<br>
}
<br>
</blockquote>
<br>
</blockquote>
<p>It looks good to me.</p>
<p><span style="color: rgb(36, 36, 36); font-family: "Cascadia Mono", Consolas, ui-monospace, Menlo, Monaco, monospace; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: pre; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">Reviewed-by: Ravi Kishore Koppuravuri <a class="moz-txt-link-rfc2396E" href="mailto:ravi.kishore.koppuravuri@intel.com"><ravi.kishore.koppuravuri@intel.com></a></span></p>
<p><br>
</p>
</body>
</html>