<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p data-start="67" data-end="278" class="">The series of 5 patches
looks good to me. Just a small suggestion: please combine patches
3, 4, and 5 into a single patch, since they all relate to the
usage of <code data-start="228" data-end="250">asic_userq_readiness</code>
and only touch three tests.</p>
Reviewed-by Vitaly Prosyak <a class="moz-txt-link-rfc2396E" href="mailto:vitaly.prosyak@amd.com"><vitaly.prosyak@amd.com></a><br>
<p><br>
</p>
<p></p>
<div class="moz-cite-prefix">On 2025-04-29 06:36, Sunil Khatri
wrote:<br>
</div>
<blockquote type="cite" cite="mid:20250429103653.190107-1-sunil.khatri@amd.com">
<pre class="moz-quote-pre" wrap="">Add UAPI support of userq mask of ip's supporting userqueues on a
asic.
The changes have been pulled from below kernel commit.
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/archives/amd-gfx/2025-April/122559.html">https://lists.freedesktop.org/archives/amd-gfx/2025-April/122559.html</a>
Cc: Prosyak, Vitaly <a class="moz-txt-link-rfc2396E" href="mailto:Vitaly.Prosyak@amd.com"><Vitaly.Prosyak@amd.com></a>
Cc: Jesse Zhang <a class="moz-txt-link-rfc2396E" href="mailto:jesse.zhang@amd.com"><jesse.zhang@amd.com></a>
Signed-off-by: Sunil Khatri <a class="moz-txt-link-rfc2396E" href="mailto:sunil.khatri@amd.com"><sunil.khatri@amd.com></a>
---
include/drm-uapi/amdgpu_drm.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/drm-uapi/amdgpu_drm.h b/include/drm-uapi/amdgpu_drm.h
index 3f4813879..ddcda5d3b 100644
--- a/include/drm-uapi/amdgpu_drm.h
+++ b/include/drm-uapi/amdgpu_drm.h
@@ -1446,6 +1446,9 @@ struct drm_amdgpu_info_device {
__u32 csa_size;
/* context save area base virtual alignment for gfx11 */
__u32 csa_alignment;
+ /* Userq IP mask (1 << AMDGPU_HW_IP_*) */
+ __u32 userq_ip_mask;
+ __u32 pad;
};
struct drm_amdgpu_info_hw_ip {
</pre>
</blockquote>
</body>
</html>