<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> Hi, <div class="moz-cite-prefix">On 20-05-2025 22:46, <a class="moz-txt-link-abbreviated" href="mailto:sk.anirban@intel.com">sk.anirban@intel.com</a> wrote: </div> <blockquote type="cite" cite="mid:20250520171641.2421623-1-sk.anirban@intel.com"> <pre wrap="" class="moz-quote-pre">From: Sk Anirban <a class="moz-txt-link-rfc2396E" href="mailto:sk.anirban@intel.com"><sk.anirban@intel.com></a> Fetch the minimum frequency only once during GPU frequency restoration. This avoids inconsistencies caused by potential changes in the minimum frequency between multiple fetches. Signed-off-by: Sk Anirban <a class="moz-txt-link-rfc2396E" href="mailto:sk.anirban@intel.com"><sk.anirban@intel.com></a> --- tests/intel/xe_pmu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/intel/xe_pmu.c b/tests/intel/xe_pmu.c index c49cceff5..f830c5de8 100644 --- a/tests/intel/xe_pmu.c +++ b/tests/intel/xe_pmu.c @@ -390,6 +390,7 @@ static void test_gt_frequency(int fd, struct drm_xe_engine_class_instance *eci) uint32_t gt = eci->gt_id; uint32_t orig_min = xe_gt_get_freq(fd, eci->gt_id, "min"); uint32_t orig_max = xe_gt_get_freq(fd, eci->gt_id, "max"); + uint32_t current_min; uint32_t orig_rpe; uint32_t vm; int pmu_fd[2]; @@ -440,8 +441,8 @@ static void test_gt_frequency(int fd, struct drm_xe_engine_class_instance *eci) */ igt_assert(xe_gt_set_freq(fd, gt, "min", orig_min) > 0); orig_rpe = xe_gt_get_freq(fd, gt, "rpe"); - igt_assert(xe_gt_get_freq(fd, gt, "min") == orig_min || - xe_gt_get_freq(fd, gt, "min") == orig_rpe); + current_min = xe_gt_get_freq(fd, gt, "min"); + igt_assert(current_min == orig_min || current_min == orig_rpe); igt_info("Minimum frequency: requested %.1f, actual %.1f\n", min[0], min[1]);</pre> </blockquote> It looks good to me. <span style="color: rgb(36, 36, 36); font-family: "Cascadia Mono", Consolas, ui-monospace, Menlo, Monaco, monospace; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; white-space: pre; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">Reviewed-by: Ravi Kishore Koppuravuri <a class="moz-txt-link-rfc2396E" href="mailto:ravi.kishore.koppuravuri@intel.com"><ravi.kishore.koppuravuri@intel.com></a> </body> </html>