<div dir="ltr"><div>Hi all,</div><div> </div><div>Thank you Erico and Kamil for the reviews. very much appreciated. </div><div> </div><div>BR,</div><div>Dorinda.</div></div> <div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, Jun 11, 2025 at 7:05 PM Kamil Konieczny <<a href="mailto:kamil.konieczny@linux.intel.com">kamil.konieczny@linux.intel.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Erico, On 2025-06-11 at 18:10:52 +0200, Erico Nunes wrote: > Hello, > > On 6/10/25 6:30 PM, Dorinda Bassey wrote: > > This test suite adds coverage for multiple DRM ioctls specific > > to the VirtIO-GPU driver, verifying functionality such as > > resource creation, memory mapping, 3D transfers, context > > initialization, and parameter querying. > > Each test validates a key ioctl to ensure correct behavior from > > user space and backend implementations. Each subtest is > > self-contained and can be executed independently. > > > > Included subtests: > > - drm-virtgpu-map > > - drm-virtgpu-execbuffer > > - drm-virtgpu-resource-info > > - drm-virtgpu-3d-transfer-to-host > > - drm-virtgpu-3d-transfer-from-host > > - drm-virtgpu-3d-wait > > - drm-virtgpu-resource-create-blob > > - drm-virtgpu-get-caps > > - drm-virtgpu-context-init > > - drm-virtgpu-getparam > > > > How to Test with QEMU virtio-vga-gl or rustvmm vhost-device-gpu > > > > 1. Launch a QEMU guest with virtio-vga-gl > > ./build/qemu-system-x86_64 \ > > -enable-kvm \ > > -cpu host \ > > -m 4096 \ > > -machine q35 \ > > -display gtk,gl=on \ > > -vga none \ > > -device virtio-vga-gl \ > > -drive file=image.qcow2,format=qcow2 \ > > -netdev user,id=n0,hostfwd=tcp::2222-:22 \ > > -device virtio-net-pci,netdev=n0 > > > > ssh into the guest and run the tests. > > > > 2. Start the vhost-device-gpu backend and Launch a QEMU > > guest with vhost-user-gpu-pci or vhost-user-vga, see guide on: > > <a href="https://crates.io/crates/vhost-device-gpu" rel="noreferrer" target="_blank">https://crates.io/crates/vhost-device-gpu</a> > > Overall this looks quite good to me. Thanks for doing this initial batch > of tests for virtio-gpu. I think it is a good start to build upon and > start enabling some more DRM tests in CIs especially since this can > astract hardware details. > > I have a couple of comments below, to consider if you will do another > respin: > > > > > > tests/drm_virtgpu.c | 425 ++++++++++++++++++++++++++++++++++++++++++++ > > tests/meson.build | 1 + > > 2 files changed, 426 insertions(+) > > create mode 100644 tests/drm_virtgpu.c > > Would it make sense for this to live in its own subdirectory? Since it > is testing "device-specific" commands (for virtio-gpu being the device). > I see that some of the other drivers have their own directory, and > currently this one is bundled together with some fairly generic DRM or > KMS API tests in meson.build. > But I'm not sure if there is a policy for this so I'd leave it to the > igt maintainers. > Lets start with something simple, new folder could be created when there will be more virtgpu tests. > > +#define VIRTGPU_DEVICE "/dev/dri/card0" > > VIRTGPU_DEVICE is unused since an earlier revision, so it can be removed. > Thank you for spotting this. Regards, Kamil > > +static const struct { > > + const char *name; > > + uint64_t id; > > +} params[] = { > > + {"3D_FEATURES", VIRTGPU_PARAM_3D_FEATURES}, > > + {"CAPSET_QUERY_FIX", VIRTGPU_PARAM_CAPSET_QUERY_FIX}, > > + {"RESOURCE_BLOB", VIRTGPU_PARAM_RESOURCE_BLOB}, > > + {"HOST_VISIBLE", VIRTGPU_PARAM_HOST_VISIBLE}, > > + {"CROSS_DEVICE", VIRTGPU_PARAM_CROSS_DEVICE}, > > + {"CONTEXT_INIT", VIRTGPU_PARAM_CONTEXT_INIT}, > > + {"SUPPORTED_CAPSET_IDs", VIRTGPU_PARAM_SUPPORTED_CAPSET_IDs}, > > + {"EXPLICIT_DEBUG_NAME", VIRTGPU_PARAM_EXPLICIT_DEBUG_NAME}, > > +}; > > Might make sense to move this params array to the "drm-virtgpu-getparam" > subtest since it is only used there. > > Considering these you can add my: > Reviewed-by: Erico Nunes <<a href="mailto:ernunes@redhat.com" target="_blank">ernunes@redhat.com</a>> > > Thanks > > Erico > </blockquote></div>