<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hi Jeevan,</p>
<div class="moz-cite-prefix">On 7/14/2025 3:58 PM, Jeevan B wrote:<br>
</div>
<blockquote type="cite" cite="mid:20250714102812.212333-1-jeevan.b@intel.com">
<pre wrap="" class="moz-quote-pre">Adding the Panel Replay support check later in the test was causing
an invalid skip, since the test disables PSR/PR in output_constraint().
Move the check earlier to ensure correct capability detection and avoid
unintended skips.
Fixes: 7da0c57182cc ("tests/kms_vrr: Skip LOBF test if PR is not supported on sink")
Signed-off-by: Jeevan B <a class="moz-txt-link-rfc2396E" href="mailto:jeevan.b@intel.com"><jeevan.b@intel.com></a>
---
tests/kms_vrr.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 9c2c4ac92..85a90bb25 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -960,6 +960,14 @@ static bool output_constraint(data_t *data, igt_output_t *output, uint32_t flags
return false;
}
+ if (flags & TEST_LINK_OFF) {
+ if (!psr_sink_support(data->drm_fd,
+ data->debugfs_fd, PR_MODE, NULL)) {
+ igt_info("LOBF not supported\n");
+ return false;
+ }
+ }
+</pre>
</blockquote>
<p>Consolidate TEST_LINK_OFF condition to avoid duplicated checks. </p>
<p>imho, This should be as below:<br>
if (flags & TEST_LINK_OFF) {</p>
<p> <span style="white-space: pre-wrap">igt_require_f(psr_sink_support(data->drm_fd, </span><span style="white-space: pre-wrap">data->debugfs_fd, PR_MODE, NULL), </span><span style="white-space: pre-wrap">"LOBF not supported");</span></p>
<p><span style="white-space: pre-wrap"> </span><span style="white-space: pre-wrap">if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) || </span><span style="white-space: pre-wrap">psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))</span></p>
<p><span style="white-space: pre-wrap">}</span></p>
<blockquote type="cite" cite="mid:20250714102812.212333-1-jeevan.b@intel.com">
<pre wrap="" class="moz-quote-pre">
if (flags & TEST_LINK_OFF) {
if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||
psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))
@@ -1051,11 +1059,6 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags)
continue;
}
- if (flags == TEST_LINK_OFF)
- igt_require_f(psr_sink_support(data->drm_fd,
- data->debugfs_fd, PR_MODE, output),
- "LOBF not supported");
-
igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe), output->name)
test(data, pipe, output, flags);
</pre>
</blockquote>
</body>
</html>