<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hi Jee</p>
<div class="moz-cite-prefix">On 7/14/2025 8:25 PM, Jeevan B wrote:<br>
</div>
<blockquote type="cite" cite="mid:20250714145556.213318-1-jeevan.b@intel.com">
<pre wrap="" class="moz-quote-pre">Adding the Panel Replay support check later in the test was causing
an invalid skip, since the test disables PSR/PR in output_constraint().
Move the check earlier to ensure correct capability detection and avoid
unintended skips.
v2: Refactor TEST_LINK_OFF logic to avoid duplicate conditions.
Fixes: 7da0c57182cc ("tests/kms_vrr: Skip LOBF test if PR is not supported on sink")
Signed-off-by: Jeevan B <a class="moz-txt-link-rfc2396E" href="mailto:jeevan.b@intel.com"><jeevan.b@intel.com></a>
---
tests/kms_vrr.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 9c2c4ac92..233143770 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -961,6 +961,12 @@ static bool output_constraint(data_t *data, igt_output_t *output, uint32_t flags
}
if (flags & TEST_LINK_OFF) {
+ if (!psr_sink_support(data->drm_fd,
+ data->debugfs_fd, PR_MODE, NULL)) {
+ igt_info("LOBF not supported\n");
+ return false;
+ }
+</pre>
</blockquote>
<p>LGTM,</p>
<p><span style="background:white">Reviewed-by:
Naladala Ramanaidu <a class="moz-txt-link-rfc2396E" href="mailto:ramanaidu.naladala@intel.com"><ramanaidu.naladala@intel.com></a></span>
</p>
<blockquote type="cite" cite="mid:20250714145556.213318-1-jeevan.b@intel.com">
<pre wrap="" class="moz-quote-pre">
if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||
psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL))
psr_disable(data->drm_fd, data->debugfs_fd, NULL);
@@ -1051,11 +1057,6 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags)
continue;
}
- if (flags == TEST_LINK_OFF)
- igt_require_f(psr_sink_support(data->drm_fd,
- data->debugfs_fd, PR_MODE, output),
- "LOBF not supported");
-
igt_dynamic_f("pipe-%s-%s",
kmstest_pipe_name(pipe), output->name)
test(data, pipe, output, flags);
</pre>
</blockquote>
</body>
</html>