[PATCH libevdev 3/3] Make the tests optional to drop unneeded dependencies

[Peter Hutterer]

On Mon, Aug 12, 2013 at 10:59:40AM +0200, Benjamin Tissoires wrote:
> On Fri, Aug 9, 2013 at 8:40 AM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> > libevdev has no external dependencies and both check and libudev are
> > only required for running the unit-tests. Make them optional.
> >
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> > ---
> 
> I remember a patch in evemu saying something like "disabling the tests
> by default is the best way to never update them"... However, if these
> unit tests takes a long time to be run, it makes sense to not enable
> them by default.

two reasons, trying to hit for the middle ground here:
- libevdev has no other dependency and the uinput backend will require
  libudev. that's not need for libevdev directly either.
- the tests create uinput devices and thus need to be root, so once the
  tests are enabled make distcheck (which is part of some workflows) won't
  succeed unless the caller is root.

as long as the dependency is there, the tests still get built all the time.


> Otherwise, the patch looks good:
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires at gmail.com>

thanks.

Cheers,
   Peter