[PATCH libevdev 0/6] uinput device creation support

Benjamin Tissoires benjamin.tissoires at gmail.com
Wed Aug 14 06:26:55 PDT 2013


On Tue, Aug 13, 2013 at 12:39 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
>
> This patchset enables libevdev support for creating uinput devices.
> The motivation for this is pretty much the same as for libevdev - to
> stop manual bitflags, etc. Plus, it generally makes the code a lot nicer
> to read than uinput code.
>
> Please have a look at the API as well as the code. I think it's
> workable, but any suggestions are welcome.
>

ok, first series done. On overall, I think it's good.
The two concerns I have (as mentioned in the reviews):
- I don't really like the "fd" parameter for creating a new uinput device
- we should provide a way in libevdev_uinput API to retrieve the
created devnode, so that users do not have to deal with udev or sth
else.

Cheers,
Benjamin


More information about the Input-tools mailing list