[PATCH v2 libevdev] Pass --no-print-directory to make

[Peter Hutterer]

On 23/08/13 18:15 , David Herrmann wrote:
> Hi
>
> On Fri, Aug 23, 2013 at 2:12 AM, Peter Hutterer
> <peter.hutterer at who-t.net> wrote:
>> From: David Herrmann <dh.herrmann at gmail.com>
>>
>> The "Entering/Leaving directroy /xyz" messages only add noise to
>> make-output. Even without we still get short hints which directory is
>> currently processed. Compare the two outputs below:
>>
>> With --no-print-directory added:
>>    make --no-print-directory all-recursive
>>    Making all in doc
>>    doxygen libevdev.doxygen
>>    Making all in libevdev
>>    python2 ./make-event-names.py --output=c > event-names.h
>>    make  all-am
>>      CC       libevdev.lo
>>      CCLD     libevdev.la
>>    Making all in tools
>>      CC       libevdev-events.o
>>      CCLD     libevdev-events
>>    Making all in test
>>      CC       test-main.o
>>      CC       test-event-names.o
>>      CC       test-libevdev-init.o
>>      CC       test-libevdev-has-event.o
>>      CC       test-int-queue.o
>>      CC       test-libevdev-events.o
>>      CC       libevdev.o
>>      CC       test-common-uinput.o
>>      CC       test-common.o
>>      CCLD     test-libevdev
>>
>> Without it:
>>    make  all-recursive
>>    make[1]: Entering directory `/home/david/dev/libevdev'
>>    Making all in doc
>>    make[2]: Entering directory `/home/david/dev/libevdev/doc'
>>    doxygen libevdev.doxygen
>>    make[2]: Leaving directory `/home/david/dev/libevdev/doc'
>>    Making all in libevdev
>>    make[2]: Entering directory `/home/david/dev/libevdev/libevdev'
>>    python2 ./make-event-names.py --output=c > event-names.h
>>    make  all-am
>>    make[3]: Entering directory `/home/david/dev/libevdev/libevdev'
>>      CC       libevdev.lo
>>      CCLD     libevdev.la
>>    make[3]: Leaving directory `/home/david/dev/libevdev/libevdev'
>>    make[2]: Leaving directory `/home/david/dev/libevdev/libevdev'
>>    Making all in tools
>>    make[2]: Entering directory `/home/david/dev/libevdev/tools'
>>      CC       libevdev-events.o
>>      CCLD     libevdev-events
>>    make[2]: Leaving directory `/home/david/dev/libevdev/tools'
>>    Making all in test
>>    make[2]: Entering directory `/home/david/dev/libevdev/test'
>>      CC       test-main.o
>>      CC       test-event-names.o
>>      CC       test-libevdev-init.o
>>      CC       test-libevdev-has-event.o
>>      CC       test-int-queue.o
>>      CC       test-libevdev-events.o
>>      CC       libevdev.o
>>      CC       test-common-uinput.o
>>      CC       test-common.o
>>      CCLD     test-libevdev
>>    make[2]: Leaving directory `/home/david/dev/libevdev/test'
>>    make[2]: Entering directory `/home/david/dev/libevdev'
>>    make[2]: Leaving directory `/home/david/dev/libevdev'
>>    make[1]: Leaving directory `/home/david/dev/libevdev'
>>
>> We don't really win any useful information from these messages.
>>
>> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
>> ---
>> Changes to v1:
>> - use same approach as automake's _0 and _1 tactic to enable/disable the
>>    flags (thanks to Chris Bagwell)
>>
>> Decided against using --print-directory in _1 to just use the default flags
>> instead of overriding whatever else may be set in the environment.
>>
>>   Makefile.am | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Makefile.am b/Makefile.am
>> index e622c1d..95a16ea 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -1,4 +1,8 @@
>>   ACLOCAL_AMFLAGS = -I m4 ${ACLOCAL_FLAGS}
>> +PRINT_DIRECTORY_FLAGS_1=
>> +PRINT_DIRECTORY_FLAGS_0=--no-print-directory
>> +PRINT_DIRECTORY_FLAGS_=$(PRINT_DIRECTORY_FLAGS_$(AM_DEFAULT_VERBOSITY))
>> +AM_MAKEFLAGS = $(PRINT_DIRECTORY_FLAGS_$(V))
>
> I read the G+ message, it is definitely the nicest hack of all. And
> looks quite automake'ish.
> I guess for $(V)>1 it will still work as the variable is undefined =>
> empty?

correct, it expands to PRINT_DIRECTORY_FLAGS_, and thus takes the 
default verbosity.

Cheers,
   Peter

I looked at a automake "Makefile" and they do exactly the
> same... so:
>
> Signed-off-by: David Herrmann <dh.herrmann at gmail.com>



>>   SUBDIRS = doc libevdev tools test
>>
>>   pkgconfigdir = $(libdir)/pkgconfig
>> --
>> 1.8.2.1
>>