[PATCH libevdev] build: set aux-dir

[Peter Hutterer]

On Mon, Nov 18, 2013 at 07:32:40AM +0100, David Herrmann wrote:
> Hi Peter
> 
> On Mon, Nov 4, 2013 at 3:43 PM, David Herrmann <dh.herrmann at gmail.com> wrote:
> > If we don't set AUX_DIR, I get errors during ./configure:
> >   /bin/sh: /home/david/missing: No such file or directory
> >   configure: WARNING: 'missing' script is too old or missing
> >
> > This error is ignored by default, but may cause failures with newer
> > autoconf versions. Simply set the AUX_DIR to "build-aux" like many other
> > autotools projects do.
> 
> Independent of the subdir-objects thingy, this fixes a real bug for
> me. Any reason not to apply this? It might have been a bit unfortunate
> to start the subdir-objects discussion on this patch, as it is totally
> unrelated.

sorry, forgot about this one. I don't have a problem with adding it per-se,
but I'd rather figure out why this breaks on your machine. once we know that
we can merge the patch but I'd like to know if this just papers over the
problem.

> >   /bin/sh: /home/david/missing: No such file or directory

this suggests that ac_aux_dir is unset in your case, but why? there's a
check for that in configure here where it should exit much earlier than
this. can you check your configure script and debug what really is happening
here?

Cheers,
   Peter

 
> > Signed-off-by: David Herrmann <dh.herrmann at gmail.com>
> > ---
> > Hi Peter
> >
> > I still get the attached errors with ./autogen.sh. I tried adding
> > "subdir-objects" but I failed horribly.. I really have no idea how that works
> > with SUBDIRS=, sorry.
> >
> > I don't know whether newer autotools will really make "subdir-objects" the
> > default, but at least they tell me they will.
> >
> > Thanks
> > David
> >
> > test/Makefile.am:6: warning: source file '$(top_srcdir)/libevdev/libevdev.c' is
> > in a subdirectory,
> > test/Makefile.am:6: but option 'subdir-objects' is disabled
> > automake: warning: possible forward-incompatibility.
> > automake: At least a source file is in a subdirectory, but the 'subdir-objects'
> > automake: automake option hasn't been enabled.  For now, the corresponding
> > output
> > automake: object file(s) will be placed in the top-level directory.  However,
> > automake: this behaviour will change in future Automake versions: they will
> > automake: unconditionally cause object files to be placed in the same
> > subdirectory
> > automake: of the corresponding sources.
> > automake: You are advised to start using 'subdir-objects' option throughout your
> > automake: project, to avoid future incompatibilities.
> > test/Makefile.am:6: warning: source file
> > '$(top_srcdir)/libevdev/libevdev-names.c' is in a subdirectory,
> > test/Makefile.am:6: but option 'subdir-objects' is disabled
> > test/Makefile.am:6: warning: source file
> > '$(top_srcdir)/libevdev/libevdev-uinput.c' is in a subdirectory,
> > test/Makefile.am:6: but option 'subdir-objects' is disabled
> > autoreconf: Leaving directory `.'
> >
> >  configure.ac | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/configure.ac b/configure.ac
> > index 894e0a6..eeb9309 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -8,6 +8,7 @@ AC_INIT([libevdev],
> >
> >  AC_CONFIG_HEADERS([config.h])
> >  AC_CONFIG_MACRO_DIR([m4])
> > +AC_CONFIG_AUX_DIR([build-aux])
> >  AC_USE_SYSTEM_EXTENSIONS
> >
> >  AM_INIT_AUTOMAKE([1.11 foreign no-dist-gzip dist-xz])
> > --
> > 1.8.4.2
> >