[PATCH libevdev 3/3] test: add a build test for -pedantic

[David Herrmann]

Hi Peter

On Fri, Nov 22, 2013 at 3:31 AM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
>  test/.gitignore              | 1 +
>  test/Makefile.am             | 5 ++++-
>  test/test-compile-pedantic.c | 6 ++++++
>  3 files changed, 11 insertions(+), 1 deletion(-)
>  create mode 100644 test/test-compile-pedantic.c
>
> diff --git a/test/.gitignore b/test/.gitignore
> index 3117f82..08a722d 100644
> --- a/test/.gitignore
> +++ b/test/.gitignore
> @@ -1,2 +1,3 @@
>  gcov-report.txt
>  test-libevdev
> +test-compile-pedantic
> diff --git a/test/Makefile.am b/test/Makefile.am
> index a232f86..8cdd370 100644
> --- a/test/Makefile.am
> +++ b/test/Makefile.am
> @@ -1,5 +1,5 @@
>  if BUILD_TESTS
> -noinst_PROGRAMS = test-libevdev
> +noinst_PROGRAMS = test-libevdev test-compile-pedantic
>
>  TESTS = $(noinst_PROGRAMS)
>
> @@ -33,6 +33,9 @@ test_libevdev_SOURCES = \
>
>  test_libevdev_LDADD =  $(CHECK_LIBS) $(GCOV_LDFLAGS)
>
> +test_compile_pedantic_SOURCES = test-compile-pedantic.c
> +test_compile_pedantic_CFLAGS = $(AM_CPPFLAGS) -Wpedantic -Werror -std=c90

Why not -std=c99 and drop the two earlier patches? Or does -pedantic
not work with c99?

Anyway, I dislike changing the code just to get -pedantic working with
c89. Things like trailing semicolons make patches easier to read as no
line needs to be changed but just added. And other stuff like
lvalue-struct-initializers and friends will all break once we add
this.

Imho there're much more useful -W-flags than -pedantic. We should try
using them instead (like -Wshadow, -Wmissing-prototypes, ...). But
it's up to you. The patches look fine, so in case this is really what
we want:
Reviewed-by: David Herrmann <dh.herrmann at gmail.com>

Thanks
David

> +
>  if GCOV_ENABLED
>
>  CLEANFILES = gcov-report.txt
> diff --git a/test/test-compile-pedantic.c b/test/test-compile-pedantic.c
> new file mode 100644
> index 0000000..6faea86
> --- /dev/null
> +++ b/test/test-compile-pedantic.c
> @@ -0,0 +1,6 @@
> +#include <libevdev/libevdev.h>
> +#include <libevdev/libevdev-uinput.h>
> +
> +int main(void) {
> +       return 0;
> +}
> --
> 1.8.3.1
>
> _______________________________________________
> Input-tools mailing list
> Input-tools at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/input-tools