[PATCH libevdev 3/3] Remove warning comment from FORCE_SYNC

Peter Hutterer peter.hutterer at who-t.net
Tue Sep 10 19:12:49 PDT 2013


There is a legitimate reason for clients to force a sync on the device.
X.Org drivers lose the fd when the device is disabled and re-enabled. When
the device comes back, a simple libevdev_change_fd() doesn't update the status
on the device.

Button states, etc. may have changed, etc. So a driver may call FORCE_SYNC after
re-connecting to the fd to make sure the library and the driver get the current
state of the device.

Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
---
 libevdev/libevdev.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/libevdev/libevdev.h b/libevdev/libevdev.h
index 0fcfb70..5158586 100644
--- a/libevdev/libevdev.h
+++ b/libevdev/libevdev.h
@@ -294,9 +294,8 @@ struct libevdev;
 enum libevdev_read_flag {
 	LIBEVDEV_READ_FLAG_SYNC		= 1, /**< Process data in sync mode */
 	LIBEVDEV_READ_FLAG_NORMAL	= 2, /**< Process data in normal mode */
-	LIBEVDEV_READ_FLAG_FORCE_SYNC	= 4, /**< Pretend the next event is a SYN_DROPPED. There is
-					          no reason to ever use this except for
-						  automated tests, so don't. */
+	LIBEVDEV_READ_FLAG_FORCE_SYNC	= 4, /**< Pretend the next event is a SYN_DROPPED and
+					          require the caller to sync */
 	LIBEVDEV_READ_FLAG_BLOCKING	= 8, /**< The fd is not in O_NONBLOCK and a read may block */
 
 };
-- 
1.8.3.1



More information about the Input-tools mailing list