[PATCH libevdev 2/2] Reintroduce -fstack-protector

[David Herrmann]

Hi Giovanni

On Fri, Sep 13, 2013 at 10:49 AM, Giovanni Campagna
<scampa.giovanni at gmail.com> wrote:
> 2013/9/12 David Herrmann <dh.herrmann at gmail.com>:
>> We removed this previously due to build failures in:
>>
>>   commit 14ac764ec86452ca607403f314b0f8355d80290c
>>   Author: David Herrmann <dh.herrmann at gmail.com>
>>   Date:   Mon Sep 9 16:03:41 2013 +0200
>>
>>       build: remove -fstack-protector
>>
>> Reintroduce it but this time disable it if it's not supported. We use the
>> CC-flags testing to prevent build-failures on gcc without libssp support.
>
> Problem: you only compile check the flag, but the failure happens at link time.
> So ostree is failing again.
>
> Btw, this applies also to the LDFLAGS above, you need CC_CHECK_LDFLAGS instead.

I sent another patch to harden this a bit. I tested it with -ffoobar
and -lfoobar and both were correctly detected. If this still doesn't
catch your missing libssp support, I'm lost..

As a side note, I really think there's something wrong on your setup.
gcc shouldn't support -fstack-protector if your binutils (including
gnu-ld) are compiled without libssp support. Is there any reason you
do that? A lot of other applications (including systemd) fail to
compile on such setups as far as I see. Hmm..

Cheers
David