[PATCH libevdev 2/2] Reintroduce -fstack-protector
peter.hutterer at who-t.net
Tue Sep 17 03:59:26 PDT 2013
On Tue, Sep 17, 2013 at 07:52:38AM +1000, Peter Hutterer wrote:
> On Mon, Sep 16, 2013 at 08:44:29AM -0400, Colin Walters wrote:
> > On Mon, 2013-09-16 at 16:04 +1000, Peter Hutterer wrote:
> > > I found that the difference between CFLAGS and CPPFLAGS isn't always
> > > honoured as it should, so CPPFLAGS is the lowest common denominator.
> > Interesting; I haven't encountered that problem myself is all I can say.
> the ones where I found it to be an issue were mixed C/C++ projects, where
> AM_CFLAGS, AM_CPPFLAGS and AM_CXXFLAGS really do make a difference and you
> can end up missing out on compiler flags because they're set in AM_CFLAGS
> when they should be AM_CPPFLAGS.
> > So eve with the revert, you probably still want this attached patch?
> yep, thanks. I'm just going to assume your signed-off-by since you were
> happy to provide it in the last patch.
> merged locally, will push it asap.
> > From bbe7dfd1929d2f1de9cbbfb3602852f72a1d79b6 Mon Sep 17 00:00:00 2001
> > From: Colin Walters <walters at verbum.org>
> > Date: Mon, 16 Sep 2013 08:27:40 -0400
> > Subject: [PATCH] tools: Honor GCC_CFLAGS and GCOV_CFLAGS
> > So we get compiler warnings from tools/ too.
> > ---
> > tools/Makefile.am | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> > diff --git a/tools/Makefile.am b/tools/Makefile.am
> > index 931a7d2..c30a29c 100644
> > --- a/tools/Makefile.am
> > +++ b/tools/Makefile.am
> > @@ -1,6 +1,6 @@
> > noinst_PROGRAMS = libevdev-events
> > -AM_CPPFLAGS = -I$(top_srcdir)/libevdev
> > +AM_CPPFLAGS = $(GCC_CFLAGS) $(GCOV_CFLAGS) -I$(top_srcdir)/libevdev
> > libevdev_ldadd = $(top_builddir)/libevdev/libevdev.la
> > libevdev_events_SOURCES = libevdev-events.c
> > --
> > 1.7.1
sigh, this patch keeps on giving. I've removed the GCOV_CFLAGS here,
because we don't need them for the tools (and it breaks the build anyway).
shouldn't merge patches before the first coffee, lucky I hadn't pushed it
More information about the Input-tools