[PATCH libevdev 0/3] SYN_DROPPED syncing fixes - once again

Benjamin Tissoires benjamin.tissoires at gmail.com
Tue Apr 8 07:09:39 PDT 2014


On Mon, Apr 7, 2014 at 8:23 PM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
>
> I've spent a few days tracking down a synaptics bug that caused stuck
> touches in the driver. The cause turned out to be a double tracking ID event
> in a slot after SYN_DROPPED handling. And quite simple to reproduce too: if
> a tracking ID comes in after the SYN_DROPPED, we generate the tracking ID
> event in the sync process, but still process the actual event when it is
> read from the kernel.
>
> The (only?) solution here is to drain all events after SYN_DROPPED, sync the
> device and then continue from there.

Patch 1 and 2 are:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires at gmail.com>

For, patch 3 the drain part is fine to me, but not the tests.

Cheers,
Benjamin

>
> Cheers,
>   Peter
> _______________________________________________
> Input-tools mailing list
> Input-tools at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/input-tools


More information about the Input-tools mailing list