[PATCH evemu 7/7] python: use evemu_event_type_get_max directly

Benjamin Tissoires benjamin.tissoires at gmail.com
Fri Aug 15 10:43:37 PDT 2014


On Thu, Aug 14, 2014 at 11:29 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> On Thu, Aug 14, 2014 at 02:00:45PM -0400, Benjamin Tissoires wrote:
>> Instead of using evemu.event_get_value("EV_ABS", "ABS_MAX"), we can rely
>> on the internal libevdev API to use evemu.event_get_max("EV_ABS").
>>
>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires at gmail.com>
>> ---
>>
>> As mentioned in the cover letter, I am not sure about the benefits of
>> this one.
>
> yeah, I don't think this gives us any benefits. The libevdev one is merely
> there to avoid the various switch statements when iterating over a bunch of
> events and thus multiple event types. For evemu, I don't think this is
> needed. The only benefit we get here is to know what the libevdev-built-in
> max is, but even that probably won't give us much. Let's hold off on this
> one please.
>

Sure. That seems reasonable.

Cheers,
Benjamin


More information about the Input-tools mailing list