[PATCH libevdev] tools: print the formula to calculate resolutions

[Benjamin Tissoires]

On Thu, Dec 11, 2014 at 4:57 PM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> And encourage users to move at least 25cm, makes it a lot easier to pick the
> resolution.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---

This is fine, but maybe....

>  tools/mouse-dpi-tool.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/mouse-dpi-tool.c b/tools/mouse-dpi-tool.c
> index 2bbaca5..411fed5 100644
> --- a/tools/mouse-dpi-tool.c
> +++ b/tools/mouse-dpi-tool.c
> @@ -181,6 +181,9 @@ print_summary(struct measurements *m)
>                 printf("%8dmm   %8.2fin %8ddpi\n",
>                        (int)(inch * 25.4), inch, res);
>         }
> +       printf("If your resolution is not in the list, calculate it with:\n"
> +              "\tresolution=units moved/inches, or\n"
> +              "\tresolution=units moved/(mm * 25.4)\n");

... we could replace "units moved" by the actual values?

>  }
>
>  static inline const char*
> @@ -236,7 +239,7 @@ main (int argc, char **argv) {
>         libevdev_grab(dev, LIBEVDEV_UNGRAB);
>
>         printf("Mouse %s on %s\n", libevdev_get_name(dev), path);
> -       printf("Move the device along the x-axis.\n");
> +       printf("Move the device 250mm/10in or more along the x-axis.\n");

I find it easier to read/understand with 25cm. mm is not commonly used
as a base unit where I came from :)

Cheers,
Benjamin

>         printf("Pause 3 seconds before movement to reset, Ctrl+C to exit.\n");
>         setbuf(stdout, NULL);
>
> --
> 2.1.0
>
> _______________________________________________
> Input-tools mailing list
> Input-tools at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/input-tools