Python 3 awareness, cleanups, _call replacements

Benjamin Tissoires benjamin.tissoires at gmail.com
Tue Jan 7 18:08:56 PST 2014


On Mon, Jan 6, 2014 at 7:00 PM, Peter Hutterer <peter.hutterer at who-t.net>wrote:

> On Mon, Jan 06, 2014 at 02:37:39PM -0500, Benjamin Tissoires wrote:
> > Hi Daniel,
> >
> > thanks for submitting the v2.
> >
> > I am waiting the "reviewed-by" from Peter regarding patches 2, 5 (commit
> > message changed a bit), 10 and 11, and I'll apply patches from 1 to 11
> > (except 8) so that you don't have to resend them later if a v3 is needed.
> >
> > Regarding patch 8 -> I've commented in it :)
>
> I think we can drop/squash 8.
>
> > Regarding the rest of the series, I will need a little time to review
> > it. Some seems straightforward (12, 13, 14), but I'd like some more
> > reviews/testings on 15-18 and 19!
>
> I've reviewed all of them now and they look good, bar the comments. I think
> 18 and 19 are good to go as-is, 1-14 sub 8 are good to go. I'd like the
> rename in patch 10.
>
> Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net> for that list :)
>
>
Ok, here we go:
b8f3f57..d14caab  master -> master

So I pushed: 1-7, 9, 10 + rename as requested, 11-14, 18-19 :)

Now, I'll need to properly review 15-17, but I'll do that tomorrow I hope.

Cheers,
Benjamin


More information about the Input-tools mailing list