[PATCH libevdev] fix invalid absinfo range values reported by certain mtk soc

Andreas Pokorny andreas.pokorny at canonical.com
Sun Aug 23 20:05:51 PDT 2015


Hi,


On Mon, Aug 24, 2015 at 12:25 AM, Peter Hutterer <peter.hutterer at who-t.net>
wrote:

> On Sun, Aug 23, 2015 at 06:27:28PM +0200, Andreas Pokorny wrote:
> > [...]
> > +     if (axis == ABS_MT_TRACKING_ID &&
> > +         abs_info->maximum == abs_info->minimum) {
> > +             abs_info->minimum = -1;
> > +             abs_info->maximum = 0x7FFFFFFF;
>
> the kernel #defines the tracking ID max as 0xffff (see linux/input/mt.h).
> Any reason we can't do the same?
>

Oh I was looking for that one.


>
> > +                log_bug(dev, "Invalid input_absinfo structure for
> ABS_MT_TRACKING_ID provided\n");
> > +     }
>
> To be consistent with other messages this should print the device name as
> well, so something like "Device \"%s\" has invalid ABS_MT_TRACKING_ID
> range". If you're happy with that, I can fix it up locally before pushing.
>
>
Sure sounds good.

regards
Andreas


More information about the Input-tools mailing list