[PATCH libevdev] Disable test runs on make distcheck

Benjamin Tissoires benjamin.tissoires at gmail.com
Wed Nov 30 09:32:12 UTC 2016


On Wed, Nov 30, 2016 at 10:15 AM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
> On Wed, Nov 30, 2016 at 09:25:35AM +0100, Benjamin Tissoires wrote:
>> On Wed, Nov 30, 2016 at 1:17 AM, Peter Hutterer
>> <peter.hutterer at who-t.net> wrote:
>> > The tests all need root, but running distcheck as root is not ideal. Disable
>> > the test runs (but not the build) to make it easier to verify distcheck works
>> > as intended.
>>
>> But that means when you do a new release, you need to run the tests,
>> and then distcheck through the release.sh script.
>> I know running distcheck as root is not ideal but at least we now that
>> the tests are run at each release.
>
> well, the tests *should* be round at every push, for every commit (and I
> currently do so). So the only thing distcheck does is check whether the
> tarballs are useful and that's not run often enough.
>

Right, but my question is more: "do we trust enough the release
manager to run the tests (at least before each release) or should we
*enforce* the tests to be run at least once".

After that, it's entirely up to you. I just raised my concerns (and I
will sleep tonight knowing that I did my duty today).

Cheers,
Benjamin


More information about the Input-tools mailing list