[PATCH 5/6] Allow compiling against older headers

Martin Kepplinger martink at posteo.de
Fri Sep 29 07:05:44 UTC 2017


Am 28.09.2017 23:05 schrieb Peter Hutterer:
> On Wed, Sep 27, 2017 at 10:58:30AM -0700, Dmitry Torokhov wrote:
>> Instead of requiring to compile against the newest kernel headers or
>> lose newer certain event definitions, let's check for the presence of
>> "official" defines and add missing ones ourselves (they form ABI so
>> there is no risk of them changing and getting out of sync). This 
>> allows
>> us to produce fully-functional version of evtest even if kernel 
>> headers
>> on the build system are slightly older.
>> 
>> Signed-off-by: Dmitry Torokhov <dtor at chromium.org>
> 
> tbh, I'm not a big fan of this patch. The main reason I'm keeping 
> evtest
> alive is because it's a single file and can still be compiled with a 
> simple
> 'gcc evtest.c' without having to worry about automake, dependencies, 
> etc.
> Once that advantage goes away evtest is a less-featureful cousin to
> evemu-record. And that has the advantage of being replayable.
> 
> That aside, Martin's suggestion of just adding 
> linux/input(-event-codes).h
> would be a better choice here, that should keep the `gcc evtest.c` 
> option
> alive.
> 
> Cheers,
>    Peter
> 

Dmitry's patches 1-4 don't seem to break the current state of building 
evtest
against headers. I'd like the way of just pulling the original header 
into the
project too - if you ask me, I'd open a bug for it.

atm I can't say when I have time to come up with a patch.

                               martin


ps: There is currently only one bug open [1] against evtest, but isn't 
that
resolved and couldn't it be closed?

[1] https://bugs.freedesktop.org/show_bug.cgi?id=91853


More information about the Input-tools mailing list