[PATCH libevdev] Update struct input_event

Deepa Dinamani deepa.kernel at gmail.com
Wed Jan 31 03:14:21 UTC 2018


The final patch Dmitry committed is actually a little different.
The white space differences you pointed out are not present.

-Deepa

> On Tue, Jan 30, 2018 at 9:59 AM, Martin Kepplinger <martink at posteo.de> wrote:
> Am 30.01.2018 03:14 schrieb Peter Hutterer:
>> 
>> On Mon, Jan 15, 2018 at 04:21:08PM -0800, Deepa Dinamani wrote:
>>> 
>>> The struct input_event is not y2038 safe.
>>> Update the struct according to the kernel patch:
>>> https://lkml.org/lkml/2018/1/6/324
>>> 
>>> Signed-off-by: Deepa Dinamani <deepa.kernel at gmail.com>
>> 
>> 
>> Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> While this applies and seems to come in Linux, it isn't in Linus' tree yet,
> let alone released
> as stable. Should we really update input.h this soon? As long as you
> *really* check *again*
> if something changed when 4.16 is released, it's fine, but still... why now?
> 
> Speaking of checking... Please take a look at line 26 of input.h, in other
> words, I'd propose
> adding the following hunk to your change, _IF_ at all(!):
> 
> @@ -22,8 +24,9 @@
>  * Note that __USE_TIME_BITS64 is defined by libc based on
>  * application's request to use 64 bit time_t.
>  */
> +
> struct input_event {
> -#if    (__BITS_PER_LONG != 32 || !defined(__USE_TIME_BITS64)) &&
> !defined(__KERNEL)
> +#if (__BITS_PER_LONG != 32 || !defined(__USE_TIME_BITS64)) &&
> !defined(__KERNEL)
>        struct timeval time;
> #define input_event_sec time.tv_sec
> #define input_event_usec time.tv_usec
> 
> 
> 
> thanks
> 
>                                       martin
> 


More information about the Input-tools mailing list