[PATCH v1 2/2] meson.build: use local include path for tests

Peter Seiderer ps.report at gmx.net
Thu Mar 5 20:03:44 UTC 2020


Hello Peter,

On Thu, 5 Mar 2020 13:47:08 +1000, Peter Hutterer <peter.hutterer at who-t.net> wrote:

> On Mon, Mar 02, 2020 at 04:16:28PM +0100, Peter Seiderer wrote:
> > Fixes:
> > 
> >   ../test/test-common.h: In function ‘print_event’:
> >   ../test/test-common.h:97:6: error: ‘const struct input_event’ has no member named ‘input_event_sec’
> >       ev->input_event_sec,
> >         ^
> >   ../test/test-common.h:98:6: error: ‘const struct input_event’ has no member named ‘input_event_usec’
> >       ev->input_event_usec,
> >         ^
> >   ../test/test-common.h:102:6: error: ‘const struct input_event’ has no member named ‘input_event_sec’
> >       ev->input_event_sec,
> >         ^
> >   ../test/test-common.h:103:6: error: ‘const struct input_event’ has no member named ‘input_event_usec’
> >       ev->input_event_usec,
> >         ^
> > 
> > Signed-off-by: Peter Seiderer <ps.report at gmx.net>  
> 
> applied, thanks. FTR it's easier if you submit a PR to gitlab directly
> because that way we have the CI etc. run automatically.
> 
> https://gitlab.freedesktop.org/libevdev/libevdev/-/merge_requests/42
> 

O.k., will do the next time...., did take a look at [1] first which states
'Patches ... should be submitted to the input-tools at lists.freedesktop.org mailing list',
maybe 'or alternatively/preferred submitted via gitlab merge requests if possible'?

> What I do wonder though is why the CI didn't catch this and whether it's
> worth adding a test case for this. I guess they're just older kernel
> headers?

It was (by incident) the same toolchain as used for another buildroot autobuild
failure/fix, as pointed out by Romain Naour using a '... old codesourcery
toolchain using kernel headers 3.13 ...' (see [2])...

Regards,
Peter

[1] https://gitlab.freedesktop.org/libevdev/libevdev/
[2] http://lists.busybox.net/pipermail/buildroot/2020-March/275622.html

> 
> Cheers,
>    Peter
> 



More information about the Input-tools mailing list