[Bug 77742] i965: Support instruction compaction on Gen < 6

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Apr 28 14:30:53 PDT 2014


--- Comment #2 from Matt Turner <mattst88 at gmail.com> ---
(In reply to comment #1)
> Created attachment 98113 [details] [review]
> Patch
> This patch adds support for instruction compaction to ILK and previous
> architectures (G45 and i965).
> I have access to a testing machine with ILK. I have tested it with a simple
> program which runs this new code without any visual difference. However I
> don't know this is enough or if there is another method to check whether
> this compaction code is correctly working or not by using something like a
> piglit test or other.

Great. Thanks! That was quick.

It's unclear from the i965 docs whether it actually supports instruction
compaction (the docs in those days often shipped after changes started being
made for the next chip). Eric's initial instruction compaction commit says GM45
and newer support it. We should probably change the gen4_ prefix to gm45_ and
then do two small fix ups to only allow compaction on gen4 iff brw->is_g4x is

With those changes and a passing piglit run on ILK, I think the patch would be
good to go. Feel free to send to the list. We'll find a GM45 system to test
around the office.

>From there we should test whether the original gen4 supports instruction

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140428/792fb15c/attachment.html>

More information about the intel-3d-bugs mailing list