[Bug 74005] [i965 Bisected]Piglit/glx_glx-make-glxdrawable-current fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=74005

Ian Romanick <idr at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
           Assignee|idr at freedesktop.org         |krh at bitplanet.net
                 CC|                            |idr at freedesktop.org

--- Comment #1 from Ian Romanick <idr at freedesktop.org> ---
If a regression bisects to a commit by an Intel employee, please assign the bug
to that person.  Otherwise they may not notice the bug.

Does this problem still occur?  It should have been fixed by these commits:

commit f658150639c36eda351590e757247c56507f494f
Author: Kristian Høgsberg <krh at bitplanet.net>
Date:   Wed Feb 5 11:43:58 2014 -0800

    glx: Pass NULL DRI drawables into the DRI driver for None GLX drawables

    GLX_ARB_create_context allows making a GLX context current with None
    drawable and readables, but this was never implemented correctly in GLX.
    We would create a __DRIdrawable for the None GLX drawable and pass that
    to the DRI driver and that would somehow work.  Now it's somehow broken.

    The way this should have worked is that we pass a NULL DRI drawable
    to the DRI driver when the GLX user calls glXMakeContextCurrent()
    with None for drawable and readables.

    https://bugs.freedesktop.org/show_bug.cgi?id=74143
    Signed-off-by: Kristian Høgsberg <krh at bitplanet.net>

commit 44338cd826623ae0675861015a56c528261f3fd3
Author: Kristian Høgsberg <krh at bitplanet.net>
Date:   Wed Feb 5 10:59:02 2014 -0800

    i965: Move intel_prepare_render() above first buffer access

    The driver is supposed to ensure buffers before any drawing operation, but
in
    do_blit_drawpixels() and do_blit_copypixels() we inspect the buffer format
    before calling intel_prepare_render().  That was covered up by the
    unconditional call to intel_prepare_render() in intelMakeCurrent(), but we
    now only do this on the initial intelMakeCurrent call for a context
    (to get the size for the initial viewport values).

    https://bugs.freedesktop.org/show_bug.cgi?id=74083

    Signed-off-by: Kristian Høgsberg <krh at bitplanet.net>
    Tested-by: Alexander Monakov <amonakov at gmail.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140212/2f1b942f/attachment.html>