[Bug 71870] Metro: Last Light rendering issues

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=71870

--- Comment #25 from d.spitznagel at goodbytez.de ---
@Andreas: I also checked the trace from Bernd and have discoverd the same
problems.

The most important hint is in your 2nd line...

.....It begins with warnings regarding __,...

This is because you mesa developers decided to forbid macro names starting with
"__".

Please, don't misuderstand me. I don't wanna blame here anybody an you make a
great job, but the specs for GLSL say that macro names starting with "__" * or
"GL_" are reserved for FUTURE use.

During my internet exercise regarding this problem I have found more games
having the same "lightning" problems when using mesa...second live, rust
(maybe), ...

So since GLSL doesn't FORBID macro names with "__" there should be some kind of
check against it.
For example:
If games run with GLSL 1.50 allow double underscores but disallow with GLSL X.X
where double underscores are really DISALLOWED by specs.
Maybe there is a smarter way, I don't know, this is up to you.

For now I solved this by removing the check from src/glsl/glcpp/glcpp-parse.c.
Compiled mesa after that, and voila Metro LL has no lightning problems anymore
(look at my attachment).

<<<<
    if (strstr(identifier, "__")) {
        glcpp_error (loc, parser, "Macro names containing \"__\" are
reserved.\n");
    }
>>>>

Would be great if you find a solution for this, so I don't need to remove this
on every new mesa release I wanna use to play Metro LL.

Beside this...
Thanks to Xonar (a steam user) who showed me a path to solve this problem for
me through the steam community.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140215/066f8f01/attachment.html>