[Bug 71870] Metro: Last Light rendering issues

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=71870

--- Comment #33 from Ian Romanick <idr at freedesktop.org> ---
I think it's pretty clear in the GLSL spec that using __ in a name is an error.
 Section 3.6 (Keywords) says:

    "The following are the language's keywords and (after preprocessing)
    can only be used as described in this specification, or a compile-
    time error results:"

Later the same section also says:

    "In addition, all identifiers containing two consecutive underscores
    (__) are reserved as possible future keywords."

This language has existed since GLSL 1.10.

Section 3.3 (Preprocessor) says:

    "All macro names containing two consecutive underscores ( __ ) are
    reserved for future use as predefined macro names.   All macro
    names prefixed with “GL_” (“GL” followed by a single underscore)
    are also reserved."

The preprocessor restriction was added in GLSL 1.30, and it has always existed
in GLSL ES.

There isn't any justification for a GLSL 1.50 shader using __, in any capacity,
to compile.  This is an application bug, so we'll follow up with the
application vendor.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140216/7c14793e/attachment.html>