[Bug 74083] New: [regression,i965] 11baad35 breaks switching drawables

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=74083

          Priority: medium
            Bug ID: 74083
                CC: krh at bitplanet.net
          Assignee: idr at freedesktop.org
           Summary: [regression,i965] 11baad35 breaks switching drawables
        QA Contact: intel-3d-bugs at lists.freedesktop.org
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: amonakov at gmail.com
          Hardware: Other
            Status: NEW
           Version: git
         Component: Drivers/DRI/i965
           Product: Mesa

Created attachment 92812
  --> https://bugs.freedesktop.org/attachment.cgi?id=92812&action=edit
reproducer

The following commit introduced a regression in case an application thread
attempted to bind a GLX context to two different drawables in succession.  When
the second drawable is bound, brw->ctx.ViewportInitialized is not reset, so
intel_prepare_render is not called.  A standalone testcase is attached.

commit 11baad35088dfd4bdabc1710df650dbfb413e7a3
Author: Kristian Høgsberg <krh at bitplanet.net>
Date:   Tue Jan 21 12:17:03 2014 -0800

    intel: Fix initial MakeCurrent for single-buffer drawables

    Commit 05da4a7a5e7d5bd988cb31f94ed8e1f053d9ee39 attempts to eliminate the
    call to intel_update_renderbuffer() in the case where we already have a
    drawbuffer for the drawable.  Unfortunately this only checks the
    back left renderbuffer, which breaks in case of single buffer drawables.

    This means that the initial viewport will not be set in that case. 
Instead,
    we now check whether the initial viewport has not been set, in which case
    we call out to intel_update_renderbuffer().

    https://bugs.freedesktop.org/show_bug.cgi?id=73862

    Signed-off-by: Kristian Høgsberg <krh at bitplanet.net>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140126/c265847d/attachment.html>