[Bug 79903] [HSW Bisected]Some Piglit and Ogles2conform cases fail

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=79903

Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Kenneth Graunke <kenneth at whitecape.org> ---
Fixed.

commit a2ad771671d94feae16b35c26ed4d1907f74f50e
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Tue Jun 10 18:50:03 2014 -0700

    i965: Fix Haswell discard regressions since Gen4-5 line AA fix.

    In commit dc2d3a7f5c217a7cee92380fbf503924a9591bea, Iago accidentally
    moved fire_fb_write() above the brw_pop_insn_state(), which caused the
    SEND to lose its predication and change from WE_normal to WE_all.
    Haswell uses predicated SENDs for discards, so this broke Piglit's
    tests for discards.

    We want the Gen4-5 MOV to be uncompressed, unpredicated, and unmasked,
    but the actual FB write itself should respect those.  So, pop state
    first, and force it again around the single MOV.

    Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
    Reviewed-by: Matt Turner <mattst88 at gmail.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79903

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140612/2ca3e94c/attachment.html>