[Bug 78665] macros in builtin_functions.cpp make invalid assumptions about M_PI definitions

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue May 13 08:40:53 PDT 2014


https://bugs.freedesktop.org/show_bug.cgi?id=78665

Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|idr at freedesktop.org         |mattst88 at gmail.com

--- Comment #2 from Kenneth Graunke <kenneth at whitecape.org> ---
This does seem really dodgy.  It seems like we ought to just do:

#define M_PIf   ((float) M_PI)
#define M_PI_2f ((float) M_PI_2)
#define M_PI_4f ((float) M_PI_4)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140513/dc6b187d/attachment.html>


More information about the intel-3d-bugs mailing list