[Bug 85260] New: 'write' may be used uninitialized in fs_visitor::emit_repclear_shader

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=85260

            Bug ID: 85260
           Summary: 'write' may be used uninitialized in
                    fs_visitor::emit_repclear_shader
           Product: Mesa
           Version: git
          Hardware: Other
                OS: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/DRI/i965
          Assignee: jason at jlekstrand.net
          Reporter: idr at freedesktop.org
        QA Contact: intel-3d-bugs at lists.freedesktop.org
                CC: idr at freedesktop.org

GCC generates the following warning:

brw_fs.cpp: In member function 'void fs_visitor::emit_repclear_shader()':
brw_fs.cpp:2613:21: warning: 'write' may be used uninitialized in this function
[-Wmaybe-uninitialized]

In fact, if key->nr_color_regions is 0, this will occur.  It is possible to
have a fragment shader that does not explicit write the framebuffer.  For
example, it could just generate output via atomics.  In the future, a fragment
shader could also just use image stores.

If the key->nr_color_regions == 0 case cannot occur, the code should document
the reason, and we should add an 'assume(key->nr_color_regions > 1)' before the
for-loop.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20141020/f3600bd8/attachment.html>