[Bug 83215] [SNB+]Ogles3conform ES3-CTS.shaders.struct.uniform.sampler_array_vertex crash

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=83215

Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #11 from Kenneth Graunke <kenneth at whitecape.org> ---
commit 7865026c04f6cc36dc81f993bc32ddda2806ecb5
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Thu Sep 11 22:07:41 2014 -0700

    i965/vec4: Make type_size() return 0 for samplers.

    The FS backend has always used 0, and the VS backend has always used 1.
    I think 1 is just working around other problems, and is incorrect.
    Samplers are baked in; nothing uses the UNIFORM register we would
    create, and we shouldn't upload any constant values for them.

    Fixes ES3-CTS.shaders.struct.uniform.sampler_array_vertex.

    Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
    Cc: mesa-stable at lists.freedesktop.org
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
    Tested-by: Ian Romanick <ian.d.romanick at intel.com>

commit 2408f166db1d81f2e9cc86b3f413ddba5ba537fa
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Thu Sep 11 22:07:40 2014 -0700

    i965: Skip allocating UNIFORM file storage for uniforms of size 0.

    Samplers take up zero slots and therefore don't exist in the params
    array, nor are they included in stage_prog_data->nr_params.  There's no
    need to store their size in param_size, as it's only used for dealing
    with arrays of "real" uniforms (ones uploaded as shader constants).

    We run into all kinds of problems trying to refer to the uniform storage
    for variables that don't have uniform storage.  For one, we may use some
    other variable's index, or access out of bounds in arrays.  In the FS
    backend, our extra 2 * MaxSamplerImageUnits params for texture rectangle
    rescaling paper over a lot of problems.  In the VS backend, we claim
    samplers take up a slot, which also papers over problems.

    Instead, just skip allocating storage for variables that don't have any.

    Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
    Cc: mesa-stable at lists.freedesktop.org
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
    Tested-by: Ian Romanick <ian.d.romanick at intel.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140915/ca7a4f23/attachment.html>