[Bug 83127] [ILK Bisected]Piglit glean_texCombine fails
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Tue Sep 16 00:45:05 PDT 2014
https://bugs.freedesktop.org/show_bug.cgi?id=83127
Kenneth Graunke <kenneth at whitecape.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #12 from Kenneth Graunke <kenneth at whitecape.org> ---
commit 78bd12619474e98503965541c61c5d7e9c408110
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Fri Sep 12 17:45:30 2014 -0700
i965: Mark delta_x/y as BAD_FILE if remapped away completely.
Commit afe3d1556f6b77031f7025309511a0eea2a3e8df (i965: Stop doing
remapping of "special" regs.) stopped remapping delta_x/delta_y, and
additionally stopped considering them always-live. We later realized
delta_x was used in register allocaiton, so we actually needed to remap
it, which was fixed in commit 23d782067ae834ad53522b46638ea21c62e94ca3
(i965/fs: Keep track of the register that hold delta_x/delta_y.).
However, that commit didn't restore the "always consider it live" part.
If all the code using delta_x was eliminated, fs_visitor::delta_x would
be left pointing at its old register number. Later code in register
allocation would handle that register number specially...even though it
wasn't actually delta_x.
To combat this, set delta_x/y to BAD_FILE if they're eliminated, and
check for that.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83127
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Cc: "10.3" <mesa-stable at lists.freedesktop.org>
--
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140916/16c32532/attachment.html>
More information about the intel-3d-bugs
mailing list