[Bug 81528] Linking of uniform struct with array of structs doesnt produce the correct outcome

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=81528

Tapani Pälli <lemody at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Tapani Pälli <lemody at gmail.com> ---
test passes fine on mesa master (71d4fc8), it was fixed by:

--- 8< ---
commit b48621c348fef53cc226b5ca8c08e4c71d24edec
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Sat Jul 19 14:14:29 2014 -0700

    glsl: Do not add extra padding to structures

    This code was attemping to align the base of the structure to the required
    alignment of the structure.  However, it had two problems:

    1. It was aligning the target structure member, not the base of the
    structure.

    2. It was calculating the alignment based on the members previous to the
    target member instead of all the members of the structure.

    Fixes gles3conform failures in:

    ES3-CTS.shaders.uniform_block.random.nested_structs.6
   
ES3-CTS.shaders.uniform_block.random.nested_structs_arrays_instance_arrays.2
   
ES3-CTS.shaders.uniform_block.random.nested_structs_arrays_instance_arrays.6
    ES3-CTS.shaders.uniform_block.random.all_per_block_buffers.5
    ES3-CTS.shaders.uniform_block.random.all_per_block_buffers.19
    ES3-CTS.shaders.uniform_block.random.all_shared_buffer.0
    ES3-CTS.shaders.uniform_block.random.all_shared_buffer.2
    ES3-CTS.shaders.uniform_block.random.all_shared_buffer.6
    ES3-CTS.shaders.uniform_block.random.all_shared_buffer.12

    v2: Fix rebase failure noticed by Matt.

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Matt Turner <mattst88 at gmail.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20140918/f13caf16/attachment-0001.html>