[Bug 91582] [bisected] Regression in DEQP gles2.functional.negative_api.texture.texsubimage2d_neg_offset

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=91582

--- Comment #3 from Eduardo Lima Mitev <elima at igalia.com> ---
The issue here is that mesa is failing the format+type+internalFormat check for
a test that expects to fail for invalid dimensions, which are checked later
down the code in texsubimage_error_check().

The format+type+internalFormat is failing because we are using the internal
format from the texture object instead of the effective internal format derived
from the format+type:

Page 127, section "3.8 Texturing" of the GLES 3.0.4 spec says:

"if internalformat is a base internal format, the effective internal format is
a sized internal format that is derived from the format and type for internal
use by the GL. Table 3.12 specifies the mapping of format and type to effective
internal formats. The effective internal format is used by the GL for purposes
such as texture completeness or type checks for CopyTex* commands. In these
cases, the GL is required to operate as if the effective internal format was
used as the internalformat when specifying the texture data."

And since the internal format is GL_RGBA, a base internal format, we should
resolve the effective internal format and use it in the validation, instead.

In this specific case, and per table 3.12, for format GL_RGB and type
GL_UNSIGNED_BYTE, the effective internal format is GL_RGB8. With that value,
the validation is ok and the test passes.   

I will write a patch for this and test for regressions. 

Thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150814/bc438bc2/attachment.html>