[Bug 93426] [SKL,BDW,BSW,BXT] CTS regression: es2-cts.gtf.gl2fixedtests.buffer_objects.buffer_object,s

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=93426

--- Comment #1 from Marta Löfstedt <marta.lofstedt at intel.com> ---
I don't think Jordans patch should be blamed in this case. I believe this is
the actual reason for the regression:

"
commit 6c3de8996fbe9447e092cc75ccdd6f720fabaf4d
Author: Marta Lofstedt <marta.lofstedt at intel.com>
Date:   Wed Aug 19 20:25:22 2015 +0200

    mesa/es3.1 : Align OpenGL ES 3.1 glBindVertexBuffer error handling with
OpenGL Core

    According to OpenGL ES 3.1 specification 10.3.1:
    "An INVALID_OPERATION error is generated if buffer is not zero
    or a name returned from a previous call to GenBuffers,
    or if such a name has since been deleted with DeleteBuffers."
    This error check was previously limited to OpenGL Core.
"

Without above patch ES31-CTS-vertex_attrib_binding.negative-bindVertexBuffer
will fail. I attach a patch that moves up the test to varray. With this patch
both GL2FixedTests.buffer_objects.buffer_objects and
ES31-CTS-vertex_attrib_binding.negative-bindVertexBuffer will pass.
Before sending it up to the mesa list. I just need to investigate if it is OK
to also move up the GL_CORE test. Judging from the comment in varray is done by
the same reason I did the test in bufferobj.c. But there could be some other
GL_CORE path to mesa_handle_bind_buffer_gen relying on this check.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20151218/b242e734/attachment.html>