[Bug 89180] [IVB regression] Rendering issues in Mass Effect through VMware Workstation

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89180

--- Comment #5 from Svyatoslav Pankratov <svyatoslav.pankratov at intel.com> ---
I have found guilty commit between 10.3 and 10.4 -    
0e2ba3ee827f77af0b1f322d95c650f6f7f4da88 (glsl: Optimize clamp(x, b, 1.0),
where b > 0.0 as max(saturate(x),b)).
http://cgit.freedesktop.org/mesa/mesa/commit/?id=0e2ba3ee827f77af0b1f322d95c650f6f7f4da88

Looks like a mistake in second part of changes:
In second condition, ir_binop_max should be replaced to ir_binop_min:
             if (outer_const->is_one() &&
is_greater_than_zero(inner_val_b->as_constant()))
                return expr(ir_binop_max, saturate(inner_val_a), inner_val_b);
             if (inner_val_b->as_constant()->is_one() &&
is_greater_than_zero(outer_const))
-               return expr(ir_binop_max, saturate(inner_val_a), outer_const);
+               return expr(ir_binop_min, saturate(inner_val_a), outer_const);
          }
       }


Issue was gone in 2 cases: 
 - optimization was deleted;
 - optimization was changed like described above.

Please check my fix or suggest more appropriate fix.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150224/93983808/attachment.html>