[Bug 91298] [BDW] piglit at spec@arb_shader_atomic_counters at unused-result intermittent failures
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Mon Jul 13 01:35:36 PDT 2015
https://bugs.freedesktop.org/show_bug.cgi?id=91298
--- Comment #1 from Chris Wilson <chris at chris-wilson.co.uk> ---
It's bad synchronisation of the read buffer:
diff --git a/tests/spec/arb_shader_atomic_counters/common.c
b/tests/spec/arb_shader_atomic_counters/common.c
index 95d809e..bf8309d 100644
--- a/tests/spec/arb_shader_atomic_counters/common.c
+++ b/tests/spec/arb_shader_atomic_counters/common.c
@@ -35,6 +35,7 @@ atomic_counters_probe_buffer(unsigned base, unsigned count,
uint32_t *p = glMapBufferRange(
GL_ATOMIC_COUNTER_BUFFER, base * sizeof(uint32_t),
count * sizeof(uint32_t), GL_MAP_READ_BIT);
+ bool pass = true;
unsigned i;
if (!p) {
@@ -43,17 +44,18 @@ atomic_counters_probe_buffer(unsigned base, unsigned count,
}
for (i = 0; i < count; ++i) {
- if (p[i] != expected[i]) {
+ uint32_t *found = p[i];
+ if (found != expected[i]) {
printf("Probe value at (%i)\n", i);
printf(" Expected: 0x%08x\n", expected[i]);
- printf(" Observed: 0x%08x\n", p[i]);
- glUnmapBuffer(GL_ATOMIC_COUNTER_BUFFER);
- return false;
+ printf(" Observed: 0x%08x\n", found);
+ pass = false;
+ break;
}
}
glUnmapBuffer(GL_ATOMIC_COUNTER_BUFFER);
- return true;
+ return pass;
}
bool
should fix up the error message.
--
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150713/832b163d/attachment.html>
More information about the intel-3d-bugs
mailing list