[Bug 89314] [HSW, regression, bisected] i965/pixel_read: Use meta_pbo_GetTexSubImage for PBO ReadPixels (ef0499af255ecd)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89314

--- Comment #11 from Neil Roberts <neil at linux.intel.com> ---
I wonder if it would be worth trying to push back a bit on the test case before
resorting to disabling the accelerated path just for converting to 1010102. The
spec for GL ES 3.1 in equation 2.3 says:

“The conversion from a floating-point value f to the corresponding unsigned
nor-
malized fixed-point value c is defined by first clamping f to the range [0, 1],
then computing:

  f = convert_float_uint(f × (2b − 1), b)      (2.3)

where convert_float_uint(r, b) returns one of the two unsigned binary integer
values with exactly b bits which are closest to the floating-point value r
(where
rounding to nearest is preferred)”

I guess that implies it's not against the spec to round either way. The weird
part is that we round differently depending on whether the application uses a
PBO or not. I can't find anything in the spec saying whether that's allowed or
not so maybe we could argue that it's allowed and the test is wrong?

It seems a shame to add extra code to Mesa which only makes the actual usage
slightly worse just to pass a test case.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150605/35b8c7af/attachment.html>