[Bug 89580] Implement a NIR -> vec4 pass

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=89580

--- Comment #14 from Eduardo Lima Mitev <elima at igalia.com> ---
(In reply to Kenneth Graunke from comment #13)
> Yeah, that definitely looks bizarre - but I think it's expected.
> 
> Fixed-function vertex programs and ARB programs go through prog_to_nir.c
> (the Mesa IR -> NIR translator), which generates load_uniform intrinsics
> directly, instead of creating uniform variables then having nir_lower_io
> lower variable access to intrinsics.  It just sets nir->num_uniforms
> directly, and brw_nir.c skips the part that inspects uniform variables when
> dealing with FF/ARB programs.
> 
>    /* Set the number of uniforms */
>    shader->num_uniforms = 4 * c->prog->Parameters->NumParameters;
> 

Thanks Jason and Kenneth! I managed to fix my implementation based on your
comments.

Just for the sake of clarity, I wonder if it is worth "fixing" the
inconsistency in nir_shader for these cases, perhaps injecting the missing
declarations or something like that. Dunno, probably not.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150506/b1028e92/attachment.html>