[Bug 90749] [BDW Bisected]dEQP-GLES3.functional.rasterization.fbo.rbo_multisample_max.primitives.lines_wide fails

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=90749

lu hua <huax.lu at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[BDW                        |[BDW
                   |Regression]dEQP-GLES3.funct |Bisected]dEQP-GLES3.functio
                   |ional.rasterization.fbo.rbo |nal.rasterization.fbo.rbo_m
                   |_multisample_max.primitives |ultisample_max.primitives.l
                   |.lines_wide fails           |ines_wide fails

--- Comment #1 from lu hua <huax.lu at intel.com> ---
Bisect shows: fe74fee8fa721a42448470e063870d24f9453dab is the first bad commit.
commit fe74fee8fa721a42448470e063870d24f9453dab
Author:     Iago Toral Quiroga <itoral at igalia.com>
AuthorDate: Tue Feb 10 16:40:46 2015 +0100
Commit:     Iago Toral Quiroga <itoral at igalia.com>
CommitDate: Tue Feb 24 08:58:54 2015 +0100

    i965: Fix non-AA wide line rendering with fractional line widths

    "(...)Let w be the width rounded to the nearest integer (...). If the
    line segment has endpoints given by (x0,y0) and (x1,y1) in window
    coordinates, the segment with endpoints (x0,y0-(w-1)/2) and
    (x1,y1-(w-1/2)) is rasterized, (...)"

    The hardware it not rounding the line width, so we should do it.

    Also, we should be careful not to go beyond the hardware limits
    for the line width after it gets rounded. Gen6-7 define a maximum line
    width slightly below 8.0, so we should advertise a maximum line
    width lower than 7.5 to make sure that 7.0 is the maximum integer
    line width that we can select. Since the line width granularity in these
    platforms is 0.125, we choose 7.375. Other platforms advertise rounded
    maximum line widths, so those are fine.

    Fixes the following 3 dEQP tests:
    dEQP-GLES3.functional.rasterization.primitives.lines_wide
    dEQP-GLES3.functional.rasterization.fbo.texture_2d.primitives.lines_wide
   
dEQP-GLES3.functional.rasterization.fbo.rbo_singlesample.primitives.lines_wi

    Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20150529/6ec5925f/attachment.html>