[Bug 92215] [Regression, bisected] arb_direct_state_access.texunits piglit test broken

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92215

            Bug ID: 92215
           Summary: [Regression, bisected]
                    arb_direct_state_access.texunits piglit test broken
           Product: Mesa
           Version: git
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: blocker
          Priority: medium
         Component: Drivers/DRI/i965
          Assignee: idr at freedesktop.org
          Reporter: mark.a.janes at intel.com
        QA Contact: intel-3d-bugs at lists.freedesktop.org

on all tested platforms, the following commit regressed
piglit.spec.arb_direct_state_access.texunits

commit a9408f3ca14f2fb6286bd66bad06ee1bde0d8697
Author: Brian Paul <brianp at vmware.com>
Date:   Wed Sep 30 11:37:16 2015 -0600

    mesa: remove _mesa_get_tex_unit_err() and fix error handling

    This helper was only called from _mesa_BindTextureUnit().  It's simpler
    to just inline it.

    The error check / code / message in the helper was incorrect.  It was
    written for glBindTextures(), not glBindTextureUnit().  The correct
    error for a bad texture unit number is GL_INVALID_VALUE.  The error
    message now reports the unit number rather than a GL_TEXTUREi enum.

    Fixes a failure in piglit's arb_direct_state_access-bind-texture-unit test.

    Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

Output from the test:

Standard Output
bin/arb_direct_state_access-texunits -auto -fbo
piglit: debug: Requested an OpenGL 3.1 Forward-Compatible Core Context, and
received a matching 3.3 context

GL_RENDERER = Mesa DRI Intel(R) Sandybridge Desktop 
GL_MAX_TEXTURE_COORDS = 8
GL_MAX_TEXTURE_IMAGE_UNITS = 16
GL_MAX_VERTEX_TEXTURE_IMAGE_UNITS = 16
GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS = 48
Unexpected GL error: GL_INVALID_VALUE 0x501
(Error at
/var/lib/jenkins/jobs/Leeroy/workspace at 3/repos/piglit/tests/spec/arb_direct_state_access/texunits.c:124)
Expected GL error: GL_INVALID_OPERATION 0x502

Standard Error

Mesa: User error: GL_INVALID_VALUE in glBindTextureUnit(unit=48)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20151001/535566c3/attachment.html>