[Bug 92371] [HSW]deqp-gles2 Functional at shaders@constant_expressions@ sutests are failing 432 of 462 available tests

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Oct 12 16:32:27 PDT 2015


https://bugs.freedesktop.org/show_bug.cgi?id=92371

Ian Romanick <idr at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO
                 CC|                            |idr at freedesktop.org,
                   |                            |mark.a.janes at intel.com

--- Comment #3 from Ian Romanick <idr at freedesktop.org> ---
(In reply to Elio from comment #0)
> Mesa: (11.2)git-

There is no such thing as 11.2.    Please include the actual GIT SHA1 that you
are testing.

> Execute: sudo ./deqp-gles2
> --deqp-case=dEQP-GLES2.functional.shaders.constant_expressions.*

DO NOT RUN TESTS AS ROOT.

(In reply to Elio from comment #2)
> gles2 at functional@shaders at constant_expressions@builtin_functions at common@abs_fl
> oat_fragment		
> Fail

All of these should be fixed by the commit below.  It looks like our CI system
isn't running these tests at all.  At least they weren't run on October 11th.

Mark: Any ideas why the
gles2 at functional@shaders at constant_expressions@builtin_functions tests aren't
being run?

Elio: If this resolves all of the failures, please close the bug.  If there are
still some failures, please provide that list.

commit 43b07eb60faba1c65fc6f7a99087d051b00e9c0f
Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Fri Oct 9 14:17:32 2015 -0700

    glsl: Allow built-in functions as constant expressions in OpenGL ES 1.00

    In d4a24745 (August 2012), Paul made functions calls not be constant
    expressions in GLSL ES 1.00.  Since this feature was added in desktop
    GLSL 1.20, we believed that it was added in GLSL ES 3.00.  That turns
    out to be completely wrong.  Built-in functions have always been allowed
    as constant expressions in GLSL ES, and the patch adds the (many) spec
    quotations to prove it.

    While we never previously encountered this, a later patch enforces a GLSL
    ES 1.00 rule that global variable initializers must be constant
    expressions.  Without this fix, several dEQP tests fail.

    Fixes:

        tests/spec/glsl-es-1.00/compiler/const-initializer/from-function.frag
        tests/spec/glsl-es-1.00/compiler/const-initializer/from-function.vert
       
tests/spec/glsl-es-1.00/compiler/const-initializer/from-sequence-in-function.frag
       
tests/spec/glsl-es-1.00/compiler/const-initializer/from-sequence-in-function.vert

    Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
    Reviewed-by: Matt Turner <mattst88 at gmail.com>
    Cc: "10.0 10.1 10.2 10.3 10.4 10.5 10.6 11.0"
<mesa-stable at lists.freedesktop.org>

    Yes, I know we don't maintain stable branches that far back, but that
    *is* how far back this bug goes!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20151012/f2187034/attachment.html>


More information about the intel-3d-bugs mailing list