[Bug 92621] [G965 ILK G45] Regression: 24 piglit regressions in glsl-1.10

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92621

--- Comment #4 from Alejandro Piñeiro (freenode IRC: apinheiro) <apinheiro at igalia.com> ---
Ok, I found the problem. Some comparisons are being wrongly removed with
unpack_flags.

When I added this function:

   bool reads_flag(unsigned c)
   {
      if (!reads_flag())
         return false;

      switch (predicate) {
      case BRW_PREDICATE_NONE:
         return false;
      case BRW_PREDICATE_ALIGN16_REPLICATE_X:
         return c == 0;
      case BRW_PREDICATE_ALIGN16_REPLICATE_Y:
         return c == 1;
      case BRW_PREDICATE_ALIGN16_REPLICATE_Z:
         return c == 2;
      case BRW_PREDICATE_ALIGN16_REPLICATE_W:
         return c == 3;
      default:
         return true;
      }
   }

I was only checking the predicate, but as the one without parameter shows:
   bool reads_flag()
   {
      return predicate || opcode == VS_OPCODE_UNPACK_FLAGS_SIMD4X2;
   }

We also need to check the opcode. 

Adding that checks fixes the regressions I tested manually. I will do a full
test and send a patch to the list soon.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20151023/c65c791f/attachment.html>