[Bug 94714] dEQP ldexp precision tests fail

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Apr 14 05:57:23 UTC 2016


Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
           Assignee|mattst88 at gmail.com          |jason at jlekstrand.net

--- Comment #2 from Kenneth Graunke <kenneth at whitecape.org> ---
Fixed in master by Jason:

commit 505a8fbdf8f2b6d2aaab5a04244cd3329f9dbe97
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Tue Apr 12 02:30:25 2016 -0700

    i965: Switch to NIR for ldexp lowering.

    The old GLSL IR based lowering doesn't quite work right in all cases,
    and fails several dEQP-GLES31 and Vulkan CTS tests.  Jason's new
    approach in NIR passes all the tests.  There's not likely to be a ton
    of advantage to lowering early in GLSL IR anyway, so...switch.

    Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    Reviewed-by: Matt Turner <mattst88 at gmail.com>

commit 4455bfa9a0cc53a3c7e3c171b022cbe6d6dcdff8
Author: Jason Ekstrand <jason.ekstrand at intel.com>
Date:   Fri Mar 25 12:12:38 2016 -0700

    nir/algebraic: Add lowering for ldexp

    The algorithm used is different from both the naive suggestion from the
    GLSL spec and the one used in GLSL IR today.  Unfortunately, the GLSL IR
    implementation that we have today doesn't handle denormals (for those that
    care) or the case where the float source is +-inf.

    Reviewed-by: Matt Turner <mattst88 at gmail.com>

Thanks Jason and Matt!

You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20160414/db43ba94/attachment.html>

More information about the intel-3d-bugs mailing list