[Bug 93696] [HSW,BDW;SKL][GLES 3.1 CTS]ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max-* fail

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Feb 18 10:29:27 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=93696

Tapani Pälli <lemody at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from Tapani Pälli <lemody at gmail.com> ---
commit 65dfb3048e8291675ca33581aeff8921f7ea509d
Author: Plamena Manolova <plamena.manolova at intel.com>
Date:   Thu Feb 11 15:00:02 2016 +0200

    compiler/glsl: Fix uniform location counting.

    This patch moves the calculation of current uniforms to
    link_uniforms, which makes use of UniformRemapTable which
    stores all the reserved uniform locations.

    Location assignment for implicit uniforms now tries to use
    any gaps left in the table after the location assignment
    for explicit uniforms. This gives us more space to store more
    uniforms.

    Patch is based on earlier patch with following changes/additions:

       1: Move the counting of explicit locations to
          check_explicit_uniform_locations and then pass
          the number to link_assign_uniform_locations.
       2: Count the number of empty slots in UniformRemapTable
          and store them in a list_head.
       3: Try to find an empty slot for implicit locations from
          the list, if that fails resize UniformRemapTable.

    Fixes following CTS tests:
       ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max
      
ES31-CTS.explicit_uniform_location.uniform-loc-mix-with-implicit-max-array

    Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
    Signed-off-by: Plamena Manolova <plamena.manolova at intel.com>
    Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93696

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20160218/3fa9dfe5/attachment.html>


More information about the intel-3d-bugs mailing list