[Bug 94188] define (or undef) defined behaves stupidly

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Feb 19 13:57:00 UTC 2016


https://bugs.freedesktop.org/show_bug.cgi?id=94188

Kenneth Graunke <kenneth at whitecape.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Kenneth Graunke <kenneth at whitecape.org> ---
Fixed in master:

commit 1c694a6c20da21f31c584fd41d28e2f03522617d
Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Wed Feb 17 17:15:23 2016 -0800

    glcpp: Disallow "defined" as a macro name.

    Both GCC and Clang disallow this, and glslang has recently started
    disallowing it as well.

    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94188
    Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
    Reviewed-by: Matt Turner <mattst88 at gmail.com>
    Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

unless of course we have to make #define defined actually work, but hopefully
not, because that would be silly and pointless.  We can always reopen or
something if that happens.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-3d-bugs/attachments/20160219/13672200/attachment.html>


More information about the intel-3d-bugs mailing list